search

stellasia / neomap

A Neo4j Desktop application to visualize nodes with geographic attributes on a map.
GNU General Public License v3.0
106 stars 13 forks source link

Update process for NEW LAYER ? #90

Open stellasia opened 3 years ago

stellasia commented 3 years ago

Also note that the added layer is still created using the data from the layer that has just been added - I was not able to understand why yet - but that's another issue.

The placeholder data we have in NEW_LAYER, has little to no association to actual layer data from the graph. Notice when you're creating the first layer from this seed data, you have to take care and fill in all fields appropriately including title, selecting from graph values to replace the placeholders. On the other hand, creating a layer (cloning) from another map-renderable layer is faster and much safer since a user changes just a subset of the fields, for example, just the render option from point to heatmap, or just the pop-up field from name to area.

Generally, it's not great practice to seed your interface with placeholder data like NEW_LAYER before you have user's data to present. In which case, I propose we move towards removing the use of NEW_LAYER and allow the following app behavior 1) creating layers from scratch, so long as we have a graph connection. 2) Allow independent updates of an existing layer. 3) Allow cloning of a layer into an exact copy of current layer, or into a variant

Originally posted by @jodom in https://github.com/stellasia/neomap/issues/89#issuecomment-760253703

stellasia commented 3 years ago

The placeholder data we have in NEW_LAYER, has little to no association to actual layer data from the graph.

For now it's true, but the goal is to improve this default by selecting the property from the graph that best matches latitude or longitude names.

Generally, it's not great practice to seed your interface with placeholder data like NEW_LAYER before you have user's data to present.

The only thing that is populated without user-data are the latitude and longitude property names, which are just there to ease the process of creating a new layer.

stellasia commented 3 years ago

After thinking more about your proposal @jodom , I think it makes sense to remove this NEW_LAYER stuff. If we want to infer some properties, we can even let the user click on a button to "auto-generate" data.

okjodom commented 3 years ago

Agreed. Should we close this issue :)

stellasia commented 3 years ago

I prefer to keep the issue open until it's fixed, even if the fix is quick.