ignore-fatal is ignoring normal errors as well

stelligent / cfn_nag

Linting tool for CloudFormation templates

MIT License

1.26k stars 212 forks source link

ignore-fatal is ignoring normal errors as well #555

Closed rbalman closed 3 years ago

rbalman commented 3 years ago

Summary I wanted to ignore non-cloudformation/fatal CloudFormation templates using --ignore-fatal but it is ignoring normal errors as well. Am I missing something here or this is the expected behavior. Please find the screenshots below for further context

Screenshots

cfn_nag_scan --input-path service.yaml
cfn_nag_scan --input-path service.yaml --ignore-fatal

arothian commented 3 years ago

Hi @BalmanRawat , thanks for the report. I agree, it looks like this is removing normal failure results as well. I'll see if we can fix this up.

arothian commented 3 years ago

@BalmanRawat , if you are able, can you try using the proposed fix in https://github.com/stelligent/cfn_nag/pull/556 and verify that this resolves your issue?

rbalman commented 3 years ago

Thank you @arothian that works.