search

stelligent / cfn_nag

Linting tool for CloudFormation templates
MIT License
1.25k stars 209 forks source link

feat(scan): add rule directory recursive #596

Closed dclayton-godaddy closed 2 years ago

dclayton-godaddy commented 2 years ago

Add the ability to lookup rules in subdirectories when using --rule-directory ./rules --rule-directory-recursive.

Parameter --rule-directory-recursive should include IAMNameRule.rb and GeneralRule.rb.

rules/
    IAM/
        IAMNameRule.rb
    GeneralRule.rb

closes #595

dsilbergleithcu-godaddy commented 2 years ago

This will definitely help some of our tooling! Great contribution @dclayton-godaddy!

arothian commented 2 years ago

Thanks for the contribution @dclayton-godaddy . Can you take a look at the rubocop failure and if possible sign the commit(s) - https://docs.github.com/articles/about-gpg/?

dclayton-godaddy commented 2 years ago

Thanks for the contribution @dclayton-godaddy . Can you take a look at the rubocop failure and if possible sign the commit(s) - https://docs.github.com/articles/about-gpg/?

sure. Thanks

dclayton-godaddy commented 2 years ago

@arothian rubocop issues have been addressed. Thank you for reviewing this change.