search

stelligent / dromedary

Sample app to demonstrate a working pipeline using Infrastructure as Code and AWS Code Services
MIT License
106 stars 100 forks source link

DromedaryRepo param is redundant and not used #60

Closed dmbettinger closed 8 years ago

dmbettinger commented 8 years ago

There’s a DromedaryRepo param in the stack with a default value of "https://github.com/stelligent/dromedary.git”. But I think it gets ignored. I think the actual github URL gets constructed from the github user and repo params.

PaulDuvall commented 8 years ago

It doesn't get ignored as it's used here, but it probably should be unnecessary as I should be using an Fn::Join to concatenate the URL from the GitHubUser and Repo parameters.

dmbettinger commented 8 years ago

Your change will bring it in line with codepipeline-cfn.json which uses GitHubUser and Repo params to configure the Source stage of the pipeline.