search

stelligent / dromedary

Sample app to demonstrate a working pipeline using Infrastructure as Code and AWS Code Services
MIT License
106 stars 100 forks source link

Unnecessary dot prefix and suffix on ProdHostedZone and Domain #65

Open PaulDuvall opened 8 years ago

PaulDuvall commented 8 years ago

Currently, the ProdHostedZone parameter requires a . prefix in the Hosted Zone. This is easy to overlook and will cause users problems. The Domain requires a . suffix after the Hosted Zone name. Both of these are necessary, but we probably shouldn't require users to care about these details. We should automatically add the . where necessary.

PaulDuvall commented 8 years ago

Use some variation of this: https://github.com/stelligent/dromedary-serverless/blob/master/pipeline/cfn/master.json#LL10-13