Closed ranim-n closed 1 month ago
57 files ±0 57 suites ±0 1m 19s :stopwatch: ±0s 970 tests +2 970 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 1 009 runs +2 1 009 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0
Results for commit 28625337. ± Comparison against base commit c9a670d3.
:recycle: This comment has been updated with latest results.
@ranim-n I did some modifications, seems good now.
Failed conditions 8.1% Duplication on New Code (required ≤ 3%)
See analysis details on SonarCloud
Test Results
57 files ±0 57 suites ±0 1m 19s :stopwatch: ±0s 970 tests +2 970 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0 1 009 runs +2 1 009 :white_check_mark: +2 0 :zzz: ±0 0 :x: ±0
Results for commit 28625337. ± Comparison against base commit c9a670d3.
This pull request removes 187 and adds 35 tests. Note that renamed tests count towards both.
``` "@id": "https://uri… "@type": "@json", … "@value": "/A/B" "@value": "/C/D" "@value": 20 "… { …, withTemporalValues=true, withAudit=false, expectation={ "@type": "https://uri.etsi.org/ngsi-ld/DateTime", … ``` ``` com.egm.stellio.search.scope.ScopeServiceTests ‑ it should retrieve the last n instances of history of scopes with aggregated values() com.egm.stellio.search.service.AttributeInstanceServiceTests ‑ it should only return the last n instances asked in an aggregated temporal query() com.egm.stellio.search.util.PatchAttributeTests ‑ [1] source={ "attribute": { "type": "Property", "value": 12.0, "observedAt": "2024-04-14T12:34:56Z" } }, target={ "attribute": { "type": "Property", "value": 12.2, "unitCode": "GRM" } }, expected={ "attribute": { "type": "Property", "value": 12.2, "unitCode": "GRM", "observedAt": "2024-04-14T12:34:56Z" } } com.egm.stellio.search.util.PatchAttributeTests ‑ [1] source={ "attribute": { "type": "Property", "value": 12.0, "observedAt": "2024-04-14T12:34:56Z", "subAttribute": { "type": "Property", "value": "subAttribute" } } }, target={ "attribute": { "type": "Property", "value": 12.2, "unitCode": "GRM", "subAttribute": { "type": "Property", "value": "newSubAttributeValue" } } }, expected={ "attribute": { "type": "Property", "value": 12.2, "unitCode": "GRM", "observedAt": "2024-04-14T12:34:56Z", "subAttribute": { "type": "Property", "value": "newSubAttributeValue" } } } com.egm.stellio.search.util.PatchAttributeTests ‑ [2] source={ "attribute": { "type": "Property", "value": { "en": "car", "fr": "voiture" } } }, target={ "attribute": { "type": "Property", "value": { "fr": "vélo", "es": "bicicleta" } } }, expected={ "attribute": { "type": "Property", "value": { "en": "car", "fr": "vélo", "es": "bicicleta" } } } com.egm.stellio.search.util.PatchAttributeTests ‑ [2] source={ "incoming": { "type": "JsonProperty", "json": { "id": 1, "b": null, "c": 12.4 }, "observedAt": "2022-12-24T14:01:22.066Z", "subAttribute": { "type": "Property", "value": "subAttribute" } } }, target={ "incoming": { "type": "JsonProperty", "json": { "id": 2, "b": "something" }, "observedAt": "2023-12-24T14:01:22.066Z" } }, expected={ "incoming": { "type": "JsonProperty", "json": { "id": 2, "b": "something" }, "observedAt": "2023-12-24T14:01:22.066Z", "subAttribute": { "type": "Property", "value": "subAttribute" } } } com.egm.stellio.search.util.PatchAttributeTests ‑ [3] source={ "attribute": { "type": "Property", "value": [ "car", "voiture" ] } }, target={ "attribute": { "type": "Property", "value": [ "vélo", "bicicleta" ] } }, expected={ "attribute": { "type": "Property", "value": [ "vélo", "bicicleta" ] } } com.egm.stellio.search.util.PatchAttributeTests ‑ [3] source={ "attribute": { "type": "VocabProperty", "vocab": "stellio" } }, target={ "attribute": { "type": "VocabProperty", "vocab": "egm" } }, expected={ "attribute": { "type": "VocabProperty", "vocab": "egm" } } com.egm.stellio.search.util.PatchAttributeTests ‑ [4] source={ "attribute": { "type": "Relationship", "object": "urn:ngsi-ld:Entity:01" } }, target={ "attribute": { "type": "Relationship", "object": "urn:ngsi-ld:Entity:02" } }, expected={ "attribute": { "type": "Relationship", "object": "urn:ngsi-ld:Entity:02" } } com.egm.stellio.search.util.PatchAttributeTests ‑ [5] source={ "attribute": { "type": "LanguageProperty", "languageMap": { "en": "train", "fr": "train" } } }, target={ "attribute": { "type": "LanguageProperty", "languageMap": { "fr": "TGV", "es": "tren" } } }, expected={ "attribute": { "type": "LanguageProperty", "languageMap": { "en": "train", "fr": "TGV", "es": "tren" } } } … ```:recycle: This comment has been updated with latest results.