stellio-hub / stellio-context-broker

Stellio is an NGSI-LD compatible context broker
https://stellio.readthedocs.io
Apache License 2.0
25 stars 11 forks source link

Implement Batch Entity Merge endpoint #1165

Closed thomasBousselin closed 3 weeks ago

thomasBousselin commented 1 month ago

Refacto avoid some code duplication in EntityOperationService and Test

github-actions[bot] commented 1 month ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

thomasBousselin commented 1 month ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 1 month ago

Test Results

   57 files  ±0     57 suites  ±0   1m 24s :stopwatch: +6s   974 tests +4    974 :white_check_mark: +4  0 :zzz: ±0  0 :x: ±0  1 013 runs  +4  1 013 :white_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit 9195e611. ± Comparison against base commit 5c63a142.

This pull request removes 202 and adds 52 tests. Note that renamed tests count towards both. ``` "@id": "https://uri… "@type": "@json", … "@value": "/A/B" "@value": "/C/D" "@value": 20 "… { …, withTemporalValues=true, withAudit=false, expectation={ "@type": "https://uri.etsi.org/ngsi-ld/DateTime", … ``` ``` com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch create should ask to create all provided entities() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch create should ask to create entities and transmit back any error() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return error messages when deletion in DB has failed() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return the list of deleted entity ids and in errors when deletion is partially successful() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch delete should return the list of deleted entity ids when deletion is successful() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch merge should ask to merge attributes of entities() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch replace should ask to replace entities() com.egm.stellio.search.service.EntityOperationServiceTests ‑ batch update should ask to update attributes of entities() com.egm.stellio.search.service.EntityOperationServiceTests ‑ processEntities should count as error a process which raises a BadRequestDataException() com.egm.stellio.search.service.EntityOperationServiceTests ‑ processEntities should count as error not processed attributes in entities() … ```

:recycle: This comment has been updated with latest results.

thomasBousselin commented 1 month ago

@ranim-n

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud