search

stelmo / TernaryDiagrams.jl

Ternary plots with Makie.jl
MIT License
25 stars 4 forks source link

Fix CI job #21

Closed theogf closed 6 days ago

theogf commented 2 weeks ago

Attempt to fix CI after #20

thomvet commented 2 weeks ago

Tests are calling Makie and opening a figure; this only works when a monitor is present or when setting headless. An example is shown here: https://github.com/MakieOrg/Makie.jl/blob/e5ace3b80659472b6b9ca9111d157c07a771ed87/.github/workflows/Docs.yml#L47

See also here: https://docs.makie.org/dev/explanations/headless

theogf commented 2 weeks ago

Tests are calling Makie and opening a figure; this only works when a monitor is present or when setting headless. An example is shown here: https://github.com/MakieOrg/Makie.jl/blob/e5ace3b80659472b6b9ca9111d157c07a771ed87/.github/workflows/Docs.yml#L47

See also here: https://docs.makie.org/dev/explanations/headless

That makes sense, it seems they only test on Linux though. We could just disable MacOS and Windows tests here?

thomvet commented 2 weeks ago

Awesome job fixing this!

theogf commented 2 weeks ago

@stelmo This should be ready to be merged! Do you think you could tag a new release at the same time?

stelmo commented 6 days ago

Hi there! Really sorry about the delay, I was writing a grant :) Will merge and release asap