search

stelzch / zotero.koplugin

Display Zotero collection on E-Readers with KOReader
GNU General Public License v3.0
45 stars 2 forks source link

FIX: Books downloaded and opened with Zotero are not marked as Reading until book is closed #12

Closed mergen3107 closed 2 months ago

mergen3107 commented 5 months ago

Hi @stelzch

Recently, we fixed an issue in the plugin that was not marking newly downloaded articles as Reading. This resulted into newly downloaded and opened not being shown in the History - Reading section. It required to exit the book - by going to FM, switching to another book, or closing the KOReader - to be able to mark it. This prevented me from quickly skimming through multiple articles back-and-forth.

The problem is solved in this line: https://github.com/stelzch/zotero.koplugin/blob/43f7e1e2498b321a2282e4f19ec44165c8fe2580/main.lua#L105 By replacing it to:

                ReaderUI:showReader(BaseUtil.realpath(full_path))

See linked comment with the fix and associated ticket in KOReader's GitHub. https://github.com/koreader/koreader/issues/11444#issuecomment-1982551502

Thank you!

hius07 commented 5 months ago

I am going to fix this at the KOReader side, so don't worry.

mergen3107 commented 5 months ago

Thank you @hius07 !

hius07 commented 5 months ago

Not related. Is the duplication on purpose? https://github.com/stelzch/zotero.koplugin/blob/43f7e1e2498b321a2282e4f19ec44165c8fe2580/main.lua#L200-L211

mergen3107 commented 2 months ago

@hius07 Sorry, I lost track. Were the changes you mentioned already done? In that case I can close this ticket.

@stelzch Can you please address the question about duplication from hius07?

Thanks guys!

mergen3107 commented 2 months ago

@hius07 Sorry, I remembered. Yes, this issue was solved. Waiting for comments from @stelzch

stelzch commented 2 months ago

@hius07 The duplication was not intentional, it must have crept in during a merge. Patch is in the pipeline. Thanks :)

Also thanks @mergen3107 for addressing the issue in KOReader.

If there are no objections I'll close the issue.

mergen3107 commented 2 months ago

@stelzch Yes, thank you!