stem-discord / stembot-issues

Issues for Nemesis in STEM Homework Helpers & Students
https://stem.help
1 stars 0 forks source link

[BUG] Top Helper Omega not clearing or updating, allowing duplicates #28

Closed MrEnginerdy closed 3 years ago

MrEnginerdy commented 3 years ago

The Top Helper Omega role is not clearing or updating when someone becomes the new #1 Top Helper, allowing multiple people to have the exclusive role.

version

To Reproduce

  1. User becomes the top helper of the week, achieving the Top Helper Ω role
  2. Another user becomes the top helper, achieving the Top Helper Ω role
  3. The previous user maintains the role instead of having it automatically removed as expected

This appears new as of around 2021-02-01 (one week ago) perhaps at the last version update. Here is where I first noticed it: https://discord.com/channels/493173110799859713/688023733587411028/806011901191651358 And here was some more commentary on it the next day: https://discord.com/channels/493173110799859713/622058199293362176/806062720234815488 It appears to still be an issue.

Expected behavior Only the #1 Top Helper of the week should have the Top Helper Omega role at any given time. It can toggle between two people if they are repeatedly passing each other for the #1 spot, but it should not be held by more than one person simultaneously.

Screenshots https://discord.com/channels/493173110799859713/688023733587411028/806059753482092564

nopeless commented 3 years ago

rEEEEEEEE

incaw commented 3 years ago

Fixed in * 1.1.5