search

stemangiola / tidySummarizedExperiment

Brings SummarizedExperiment to the tidyverse
25 stars 6 forks source link

Fix unnesting with RangedSummarizedExperiment objects #69

Closed william-hutchison closed 1 year ago

william-hutchison commented 1 year ago

Hello, this pull request fixes the error when unnesting RangedSummarizedExperiment objects. As Mike mentioned, a working version of unnest() was included in the branch adapt_to_rangedSE.

The only change required was adding a check for RangedSummarizedExperiment objects, but the function in adapt_to_rangedSE was also significantly faster, so I copied across the whole thing.

This is working well with the airway data from https://bioconductor.org/packages/release/data/experiment/html/airway.html, but let me know if there are any further issues with different data sets.

stemangiola commented 1 year ago

thanks William. As you are getting famigliar with tidy transcriptomics, next time click "CODE REVIEW" so I can check and merge.

if we break things many many users will be impacted.

have you added unit test? please check the github gives the green dot.

william-hutchison commented 1 year ago

Hi Stefano. Sorry about that, next time I will request a code review.

All tests passed on Github.

I was going to ask you about adding the unit test. Would it be okay to call the airway package just to download data for testing? Or would it better to include the data for testing within tidySummarizedExperiment?