Allow to select a slot (e.g. scaled, raw etc..) in join_features()

stemangiola / tidyseurat

Seurat meets tidyverse. The best of both worlds.

https://stemangiola.github.io/tidyseurat/

154 stars 12 forks source link

Allow to select a slot (e.g. scaled, raw etc..) in join_features() #69

Closed noriakis closed 1 year ago

noriakis commented 1 year ago

@stemangiola

I have made the following changes to join_features() and checked that R CMD CHECK does not produce any warnings or errors. I would be grateful if you could review the PR.

add params for assay slot and prefix in get_abundance_sc_wide()
make get_abundance_sc_long() handle assay and slot specification
add arguments and params for assay slot in get_abundance_sc_long()
add params for assay slot and ... in join_features()

noriakis commented 1 year ago

Thank you very much for your prompt review. I apologize for the misinterpretation of the feature. I have removed the assay argument from get_abundance_sc_long, and added a unit test for join_feature wide and long.

stemangiola commented 1 year ago

Condrats! 🎉