search

stemangiola / tidyseurat

Seurat meets tidyverse. The best of both worlds.
https://stemangiola.github.io/tidyseurat/
156 stars 12 forks source link

Documentation revision #71

Closed noriakis closed 1 year ago

noriakis commented 1 year ago

The code within R of tidyseurat has been revised to be in line with tidySingleCellExperiment.

In the example for bind_rows and bind_cols, currently ttservice::bind_rows and ttservice::bind_cols are being used. The codes within vignettes and tests are currently not touched. R CMD CHECK passes without errors or warnings.

I would be grateful if you could review the changes.

stemangiola commented 1 year ago

The code within R of tidyseurat has been revised to be in line with tidySingleCellExperiment.

In the example for bind_rows and bind_cols, currently ttservice::bind_rows and ttservice::bind_cols are being used. The codes within vignettes and tests are currently not touched. R CMD CHECK passes without errors or warnings.

I would be grateful if you could review the changes.

Another score! Thanks @noriakis!

I don't want to point you to other challenges specifically, as you have already done a lot; if you want to know more, you know when to find me :)

noriakis commented 1 year ago

Thank you very much for merging the PR, and I’m willing to contribute more to this important project!

stemangiola commented 1 year ago

Thank you very much for merging the PR, and I’m willing to contribute more to this important project!

Since you took care of the tidyseurat docs, you could replicate for tidySummarizeExperiment and close this challenge!

noriakis commented 1 year ago

Thank you for the reply. Happy to do the same for tidySummarizedExperiment!