stemmr / com.athom.trashchecker

Check when your trash will be picked up
1 stars 12 forks source link

Checking other conditions done when trashchecker returns 'false' #1

Open Amelsfort opened 7 years ago

Amelsfort commented 7 years ago

In my 'and'-column I have several checks which need to be checked before telling me to put the trash outside. The first check is to see if the trash gets collected the next day, then if it's after 18:00 and then there's a confirmation-check (asking me if I put the trash out already).

A little while ago, Homey was updated with functionality to check the conditions one after the other instead of all in parallel. Unfortunately, this doesn't seem to be working for the trashchecker: even when the trash is not collected the next day (when testing the card also shows a red cross), the other checks are still performed! Including the confirmation, which results in Homey asking me if I put the garbage out every night after 18:00.

Is this something that needs to be fixed in this app? Some way to indicate these checks have to be performed one after the other? Or it this an issue in Homey?

stemmr commented 7 years ago

Hmmm that is strange... Does everything work fine if you don't check one after each other? It would be quite strange if they added a breaking change in something so fundamental as conditional execution, I'll take a look into it.

Amelsfort commented 7 years ago

What do you mean with not checking one after each other? When I test the flow now, it performs all checks even when the trashcan-check is negative: image

Amelsfort commented 7 years ago

Never mind! It seems to be fixed by the 1.0.2 update of Homey!