search

stempler / gradle-versioneye-plugin

Plugin for Gradle to update your project's dependencies status on www.versioneye.com
MIT License
31 stars 5 forks source link

Remove versioneye.projectkey #10

Closed johnjohndoe closed 8 years ago

johnjohndoe commented 8 years ago

I asked @VersionEye the other day:

Do I have to keep versioneye.projectkey and versioneye.projectid secret or can I commit it to version control?

They replied as follows:

the project key is obsolete. It's only their for old clients. The projectID is enough for current clients.

You might want to remove versioneye.projectkey ...?

/cc @reiz

stempler commented 8 years ago

Thanks for the hint. I will take a look if this has any further implications and remove it if possible.

reiz commented 8 years ago

The projectKey was a more readable alternative for the projectID. But as it is anyway auto generated and stored in some properties file it doesn't makes much sense and is just redundant. I would like to get rid of it and clean the code base ;-)

stempler commented 8 years ago

Fixed and included in 1.1.0 release. The project key is obsolete and can be removed from gradle.properties.

johnjohndoe commented 8 years ago

:+1: I till try it out soon.

johnjohndoe commented 8 years ago

I updated to version 1.1.0 and run ./gradlew vEU. This fails with the following error:

java.lang.UnsupportedClassVersionError: org/standardout/gradle/plugin/versioneye/VersionEyePlugin : Unsupported major.minor version 52.0

stempler commented 8 years ago

This time built with Java 8 - I will try to add source and target compatibility settings for it to work with older Java versions (new issue #12). Did not think about that - the settings were not in place as it was no issue before.