search

stempler / gradle-versioneye-plugin

Plugin for Gradle to update your project's dependencies status on www.versioneye.com
MIT License
31 stars 5 forks source link

Remove duplicate notifications for upgrades #27

Closed mmoayyed closed 1 year ago

mmoayyed commented 8 years ago

I ran:

gradle versionEyeUpdate | grep Consider

and received:

Consider updating org.thymeleaf:thymeleaf-spring4 from 2.1.4.RELEASE to 3.0.1.RELEASE
Consider updating nz.net.ultraq.thymeleaf:thymeleaf-layout-dialect from 1.3.3 to 2.0.1
Consider updating org.hibernate:hibernate-core from 5.1.0.Final to 5.2.2.Final
Consider updating org.hibernate:hibernate-entitymanager from 5.1.0.Final to 5.2.2.Final
Consider updating com.zaxxer:HikariCP from 2.4.6 to 2.4.7
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.springframework.integration:spring-integration-core from 4.3.0.RELEASE to 4.3.1.RELEASE
Consider updating org.springframework.cloud:spring-cloud-starter-config from 1.1.1.RELEASE to 1.1.3.RELEASE
Consider updating org.hibernate:hibernate-core from 5.1.0.Final to 5.2.2.Final
Consider updating org.hibernate:hibernate-entitymanager from 5.1.0.Final to 5.2.2.Final
Consider updating com.zaxxer:HikariCP from 2.4.6 to 2.4.7
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.hibernate:hibernate-core from 5.1.0.Final to 5.2.2.Final
Consider updating org.hibernate:hibernate-entitymanager from 5.1.0.Final to 5.2.2.Final
Consider updating com.zaxxer:HikariCP from 2.4.6 to 2.4.7
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.hibernate:hibernate-core from 5.1.0.Final to 5.2.2.Final
Consider updating org.hibernate:hibernate-entitymanager from 5.1.0.Final to 5.2.2.Final
Consider updating com.zaxxer:HikariCP from 2.4.6 to 2.4.7
Consider updating org.json:json from 20160212 to 5.0.5
Consider updating org.json:json from 20160212 to 5.0.5

Notice how certain dependencies are reported as duplicates?

In the project I am working on, dependencies are grouped under a logical name in a somefile.gradle file. Then, the file is imported into the project and each module simply declares a need for a dependency using its logical name compile libraries.spring. This means, updating it once will affect all modules that need the dependency.

I realize that might be difficult to track and support, but perhaps as a starting point, a good option would be to simply disallow duplicate dependency upgrade notifications.

stempler commented 8 years ago

Do I understand you correctly that you have a multi-build project there? Do you use this kind of configuration?

versioneye {
  includeSubProjects = true
}

Or do you apply the plugin to each project?

mmoayyed commented 8 years ago

Yes I do:

https://github.com/apereo/cas

Looks like the plugin is applied to all: https://github.com/apereo/cas/blob/master/build.gradle#L287

With the configuration snippet you pointed out: https://github.com/apereo/cas/blob/master/build.gradle#L437

With this setup, I see duplicate messages as described.