search

stempler / gradle-versioneye-plugin

Plugin for Gradle to update your project's dependencies status on www.versioneye.com
MIT License
31 stars 5 forks source link

Add proxy support #37

Closed heri333 closed 7 years ago

heri333 commented 7 years ago

Support for configuring a HTTP proxy like for the Maven plugin seems to be missing. When the proxy is configured for Gradle the plugin fails to access www.versioneye.com.

stempler commented 7 years ago

The Groovy HTTP builder is used here and it seems it does use the Apache Http Client internally that does not pick up the settings from the default java system properties.

Here is an example of proxy configuration for the builder: https://gist.github.com/bryanchug/4172603

heri333 commented 7 years ago

Yes, but since the builder is created internally in the plugin, I cannot configure it. I'd propose adapting Util.createHttpBuilder() to check whether systemProp.http.* is set and configure the builder with those settings.

stempler commented 7 years ago

I did a pass on it but I don't really have time to test it in detail. So it would be great if you can test the current snapshot in respect to your problem.

heri333 commented 7 years ago

I've tested it only without authentication, but that worked as expected :)

stempler commented 7 years ago

Basic proxy support contained in 1.5.0 release. We'll see if there are issues w/ authentication to the proxy - probably in case someone needs NTLM authentication.