stemrollerapp / stemroller

Isolate vocals, drums, bass, and other instrumental stems from any song
https://www.stemroller.com
Other
2.62k stars 103 forks source link

Feature: Select local files #11

Closed alectrocute closed 2 years ago

alectrocute commented 2 years ago

Proposed changes –

Notes –

iffyloop commented 2 years ago

This is a great start! Really like how you put that "or select a local file" link right along with the default description. I think you're right - processQueue does need to be refactored, and that's part of the reason I'd been waiting to implement this for a while. Thank you for the PR - may take a look at it in a few days (once the Mac compatibility bugs are fixed) and see if there might be a way to do a little refactoring/cleaning before finalizing this feature. Looking forward to having this implemented!

iffyloop commented 2 years ago

Went ahead and added this feature so we can close the PR for now if that's OK with you. I did things a little differently (see this commit for details) but your work here gave me some inspiration to get started. We can continue the discussion in #3, and maybe make a new issue in the future for refactoring.