search

stemrollerapp / stemroller

Isolate vocals, drums, bass, and other instrumental stems from any song
https://www.stemroller.com
Other
2.62k stars 103 forks source link

⌘+A does not work in the search bar #5

Closed zmilonas closed 2 years ago

zmilonas commented 2 years ago

Steps to reproduce:

  1. Launch app
  2. Type in a search term like 'asda'
  3. Use a key combination of ⌘A while still having caret active in the search bar

What happens?

Nothing notable

What is expected?

The whole search bar text is highlited and selected.

Environment

Because of access only to macOS at the moment I was able to reproduce this only on the macOS build, in macOS Monterey (12.4). Version of the app is 1.0.0

I cannot reproduce this in the development version - current main branch commit

iffyloop commented 2 years ago

Hmm... that's really strange. Thanks for reporting the issue, I'll take a look at it once some other bugs have been fixed.

alectrocute commented 2 years ago

@iffyloop It's because Menu.setApplicationMenu isn't being executed with paste, copy, select, etc. options, thus preventing Command + A from being available inside the BrowserWindow.

iffyloop commented 2 years ago

Oops, yes, that probably explains why I thought it worked when testing in development (before disabling the app menu) and then it broke in production. Thanks! Should be an easy solution, will be fixed in next Mac build.

alectrocute commented 2 years ago

@iffyloop Made a PR: https://github.com/stemrollerapp/stemroller/pull/10

iffyloop commented 2 years ago

Great! Have been working on fixing Mac-related issues today so this was the perfect time for a PR :) Thanks so much!

iffyloop commented 2 years ago

Fixed in the latest release (1.1.0)! Closing.