search

stemrollerapp / stemroller

Isolate vocals, drums, bass, and other instrumental stems from any song
https://www.stemroller.com
Other
2.61k stars 103 forks source link

Bug Fixes: Update windows dependencies and add undici breaking update workaround #70

Closed lebull closed 3 months ago

lebull commented 3 months ago

One of the issues going on right now is ytdl-core updated one of their dependencies and marked it as a patch version change when it was supposed to be major(breaking).

Someone mentioned a workaround here and as of right now, it IS a workaround.

https://github.com/nodejs/undici/discussions/3010#discussioncomment-9581353

I'm sure once they get that squared away, that workaround should be removed.

A second issue I ran into is when standing up my dev workspace, a different version of ffmpeg was downloaded than what was expected.

I can split this into 2 PRs if needed, but at the very least wanted to go ahead and at least stand up something in case people wanted to continue using stemroller by building from source.

iffyloop commented 3 months ago

@lebull Thanks for submitting a PR! Have you been able to test this on both macOS and Windows? If so, I'll go ahead and pull these changes into the main branch. Otherwise, let me know if you need me (or someone else here) to test on one of their devices.

lebull commented 3 months ago

@lebull Thanks for submitting a PR! Have you been able to test this on both macOS and Windows? If so, I'll go ahead and pull these changes into the main branch. Otherwise, let me know if you need me (or someone else here) to test on one of their devices.

Hey there! I was only able to test on Windows, but it looks like you got the mac side. If there are any further reports of issues, I can acquire a mac to see if I can make further adjustments.