search

stencil-community / stencil-app-starter

Minimal starter project for building web components with Stencil
https://github.com/ionic-team/stencil
MIT License
320 stars 102 forks source link

[BUGFIX] Better gitignore settings for `www` #50

Closed Serabe closed 4 years ago

Serabe commented 6 years ago

Originally, the problem was that not having a www directory required the developer to run the server twice. This was fixed by adding a .gitkeep to www and removing www entirely from .gitignore.

This PR proposes a slightly different approach. It still ignores www but whitelists www/.gitkeep (as it was doing already with favicon.ico).

This also removes the whitelist for favicon as it is being removed by the compiler and already lives in assets.

There is a caveat with this approach and it is that the compiler removes all contents from the target directories. Expect a PR fixing this soon in stencil.

Serabe commented 6 years ago

If this is approved I'll make another to fix stencil-component-starter.

Serabe commented 4 years ago

Closing