stencil-community / stencil-app-starter

Minimal starter project for building web components with Stencil
https://github.com/ionic-team/stencil
MIT License
320 stars 102 forks source link

Build fails with errors #52

Closed aaronczichon closed 5 years ago

aaronczichon commented 6 years ago

Resources: Before submitting an issue, please consult our docs.

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):

@stencil/core@0.7.22
OR
@stencil/core@0.9.1

Node: 8.11.1

I'm submitting a ... (check one with "x") [x] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior:

yarn start works as expected. yarn build throws errors:

[ ERROR ]  No registered components found: App at new Renderer
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13549:19) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13623:30 at
           Generator.next (<anonymous>) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13603:71 at new
           Promise (<anonymous>) at __awaiter$38
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13599:12) at
           prerenderPath
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13607:12) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13753:35 at
           Generator.next (<anonymous>) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13645:71

[ ERROR ]  TypeError: Parameter "url" must be a string, not undefined at Url.parse (url.js:103:11) at Object.urlParse
           [as parse] (url.js:97:13) at getWritePathFromUrl
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:8991:38) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13775:26 at
           Generator.next (<anonymous>) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13645:71 at new
           Promise (<anonymous>) at __awaiter$39
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13641:12) at
           writePrerenderDest
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13773:12) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:13759:19

[ ERROR ]  TypeError: Cannot read property 'forEach' of undefined at addStyles
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3443:30) at
           generateHostRuleHeaders
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3369:5) at
           generateHostRule
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3360:18) at
           hydrateResultss.forEach.hydrateResults
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3346:30) at
           Array.forEach (<anonymous>) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3345:25 at
           Generator.next (<anonymous>) at
           /Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3328:71 at new Promise
           (<anonymous>) at __awaiter$13
           (/Users/aaron/sourcecode/test/my-app/node_modules/@stencil/core/dist/compiler/index.js:3324:12)

Expected behavior:

Should run yarn build correctly.

Steps to reproduce:

  1. Clone project
  2. run yarn
  3. run yarn build

Other information:

kensodemann commented 5 years ago

This should be fixed now. If someone could independently verify by doing the following it would be greatly appreciated:

  1. git clone git@github.com:ionic-team/stencil-app-starter.git
  2. cd stencil-app-starter/
  3. npm i
  4. npm run build
aaronczichon commented 5 years ago

Verified. Works 👍