stencil-community / stencil-app-starter

Minimal starter project for building web components with Stencil
https://github.com/ionic-team/stencil
MIT License
320 stars 102 forks source link

Out of the box compile error #53

Closed elylucas closed 5 years ago

elylucas commented 6 years ago

Resources: Before submitting an issue, please consult our docs.

Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below): 0.9.4

 insert the output from npm list @stencil/core here

I'm submitting a ... (check one with "x") [ X] bug report [ ] feature request [ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior:

There is a compile error from a fresh clone/npm install of the starter app project The error is:

[ ERROR ]  typescript: node_modules/@stencil/core/dist/declarations/component.d.ts, line: 192
           Interface 'HostElement' incorrectly extends interface 'HTMLElement'. Types of property 'componentOnReady'
           are incompatible. Type '() => Promise<HostElement>' is not assignable to type '() => Promise<this>'. Type
           'Promise<HostElement>' is not assignable to type 'Promise<this>'. Type 'HostElement' is not assignable to
           type 'this'.

    L192:  export interface HostElement extends HTMLElement {
    L193:      connectedCallback?: () => void;

Expected behavior:

App should compile successfully and launch in the browser Steps to reproduce:

Do a fresh git clone, npm install, and run npm start Related code:

insert any relevant code here

Other information:

Upgrading to stencil 0.9.7 fixes the issue, i will submit a PR to upgrade the starter-app to 0.9.7 and attach this issue to it

kensodemann commented 5 years ago

This should be fixed now. If someone could independently verify by doing the following it would be greatly appreciated:

  1. git clone git@github.com:ionic-team/stencil-app-starter.git
  2. cd stencil-app-starter/
  3. npm i
  4. npm run build