search

stencil-community / stencil-app-starter

Minimal starter project for building web components with Stencil
https://github.com/ionic-team/stencil
MIT License
320 stars 102 forks source link

chore(dependencies): migrate to community router package #87

Closed rwaskiewicz closed 2 years ago

rwaskiewicz commented 2 years ago

Overview

this commit updates the starter template to use the community driven version of the stencil router instead of the one that is no longer developed by the stencil team. in doing so, we uninstall the one under the 'stencil' scope and install the one under the 'stencil-community' scope.

@stencil/router@1.0.1 and @stencil-community/router@1.0.2 are nearly identical in terms of contents. @stencil/router@1.0.1 was transferred to the community model as @stencil-community/router@1.0.1 (and are entirely identical). however, v1.0.1 was never published under the @stencil-community scope due to limitations of the router's publishing infrastructure. @stencil-community/router@1.0.2 was published with minor changes to the original router necessary to publish the package. those changes can be viewed at https://github.com/stencil-community/stencil-router/compare/v1.0.1...v1.0.2

Testing

I tested this change by:

  1. Removing any node_modules I had in the past from testing this project out
  2. Running npm i to get the latest dependencies (including the community router)
  3. Ran npm run build to build the project
  4. Ran npm t to run the unit tests
  5. Smoke tested the project by running npm start and verifying that navigation still worked
david-poindexter commented 2 years ago

Thanks @rwaskiewicz - I'll try to test this out a bit later and process the PR if all looks good!

rwaskiewicz commented 2 years ago

No worries @david-poindexter, glad you're feeling better! 🙂