search

stencil-community / stencil-postcss

Autoprefixer plugin for Stencil
https://www.npmjs.com/package/@stencil-community/postcss
Other
30 stars 24 forks source link

now uses postcss 8 #31

Closed jagreehal closed 3 years ago

jagreehal commented 3 years ago

This PR changes postcss to version 8 and updates other dependencies

claviska commented 3 years ago

This updates quite a few other things, which I think is fine. Looks like there's only one breaking change between np@5 => np@7 but it shouldn't affect anything.

My only concern is that PostCSS 8 dropped support for Node 12, which is Stencil 2's minimum version for Node. Not sure if this would constitute a breaking change, but it may stop working for Node 12 users. On the other hand, there's no minimum Node version stated for this repo so it's sort of a gray area. 🤔

claviska commented 3 years ago

After talking with the team, we're going to add a minimum Node version to the readme and release the plugin with this change as 2.0. Thanks!