search

stencilproject / Stencil

Stencil is a simple and powerful template language for Swift.
https://stencil.fuller.li
BSD 2-Clause "Simplified" License
2.34k stars 223 forks source link

Fix Swift 4 compilation error #149

Closed dcwatson closed 6 years ago

dcwatson commented 6 years ago

Installing 0.10.0 on Xcode 9.1/Swift 4 results in a compilation error to the effect of "Swift 4 subscripts returning string obsoleted". Not sure if this was a more recent change in 9.1, since I see you're already testing on Xcode 9.

kylef commented 6 years ago

@dcwatson, Thanks for the PR. Would you be able to add an extra testing matrix for Xcode 9.1 since this problem is only with that version of Xcode (if I understand correctly). You can copy the lines from https://github.com/kylef/Stencil/blob/master/.travis.yml#L6-L8 and update for Xcode 9.

OneSman7 commented 6 years ago

Waiting for this to be released in pod. For now will make these chages directly in library code.

dcwatson commented 6 years ago

Welp, the xcode9.1 tests ran successfully, not sure why the Swift 4 linux tests started failing, I didn't change anything else...

dcwatson commented 6 years ago

Thanks! And thanks for the project, it's feels like home as a Django guy getting his feet wet with Swift.