Closed ilyapuchka closed 6 years ago
@kylef I've simplified this a lot by storing filenames and token positions at parsing time instead of calculating them at rendering time, now it looks much closer to what you've started in #82 .
@kylef this started to fail on swift 3.1 with some creepy compiler error. Maybe we should just drop it already?
Whoa this looks cool. I'd like to +1 here so somebody from the team takes a look :)
@ilyapuchka Any idea how hard it'd be to rebase/rework this on master for you? While this may not seem a "flashy" issue with fancy new features, it could end up being the most useful PR of all those that are open right now for template writers.
@djbe I've updated this with the latest master. If you are going to merge any PRs please merge this first.
Seeing as you'd rather merge this first, I'll review this one before the others.
@djbe fixed indentations
@kylef this is probably a leftover from when I was using it to render error in inheritance nodes. Not needed now, removed in 92ebfe5
@kylef you'd like to add something?
Seeing as there's no more feedback, and this PR is GTM for me, we can go on to the next PRs 🎉
Original PR #146
Example error logs: