search

stencilproject / Stencil

Stencil is a simple and powerful template language for Swift.
https://stencil.fuller.li
BSD 2-Clause "Simplified" License
2.34k stars 221 forks source link

Editor and IDE support #222

Closed svanimpe closed 5 years ago

svanimpe commented 5 years ago

I think the success of a project like Stencil depends in part on its editor and IDE support. I started out using Stencil with a Django plugin (to get some syntax highlighting at least), but found that less than ideal, which is why I built something specifically for Stencil. Earlier this year I wrote a TextMate bundle (https://github.com/svanimpe/stencil.tmbundle) and used that to build a VS Code extension (https://github.com/svanimpe/vscode-stencil). The latter has proven quite popular, with over 500 installs.

Unfortunately, I don't have the time to follow the repository closely and read every single commit to check if a change requires an update to the grammar. If possible, I would like to donate my work to the Stencil project.

Are you interested in this?

AliSoftware commented 5 years ago

That's awesome! 😍

I think that works be 👌 to have those located in the stencilproject org to have those considered "official". We'd obviously give you full push access to it if we migrate then here.

Tbh I'm not sure we'll have more time and bandwidth than you to maintain them, but at least if we host them here and link to them in the main repo and wiki and docs etc, hopefully it will allow more contributors to help us maintain those at least 😉

svanimpe commented 5 years ago

How shall we proceed with this? It may be easiest the keep the repos separate and simply transfer ownership to stencilproject (instead of merging everything into one repo)?

AliSoftware commented 5 years ago

Yeah transferring ownership is the right move 👍

svanimpe commented 5 years ago

It seems I need permission to do that. Can you add me?

AliSoftware commented 5 years ago

Sure! Just did it 👍

svanimpe commented 5 years ago

The projects have been transferred. I'll go through the READMEs tomorrow to see what needs updating. If you spot anything, feel free to let me know.

W.r.t. the VS Code Marketplace: I'll update the links, but it may be easier (for continuity) to keep the extension under my account? I'll just tag and push a new version when we have one.

AliSoftware commented 5 years ago

Awesome! Thanks!

I have no idea how the VSCode marketplace works and if you can transfer ownership or add owners or something (never really used VSCode personally yet). But I think given you're the one who did all the work on those plugins that your name and ownership should stay indeed, to keep the credits where it's due.

svanimpe commented 5 years ago

The READMEs for both repositories have been updated and a new version of the extension has been pushed (with updated metadata).

AliSoftware commented 5 years ago

I think it would be nice to add a mention of those in the docs in this Stencil repo too, to let people know it exists 👍

ilyapuchka commented 5 years ago

@svanimpe with the new organization will it make sense to move those plugins under StencilProject namespace? This might help to keep them up to date.

yonaskolb commented 5 years ago

@ilyapuchka I believe that’s what happened https://github.com/stencilproject/vscode-stencil

ilyapuchka commented 5 years ago

Oh nice, didn't notice when that has happened. I suppose we can close this then

ilyapuchka commented 5 years ago

And I didn't read the discussion =)