stencilproject / Stencil

Stencil is a simple and powerful template language for Swift.
https://stencil.fuller.li
BSD 2-Clause "Simplified" License
2.34k stars 224 forks source link

Prefer DynamicMemberLookup over KVC #342

Closed art-divin closed 1 year ago

art-divin commented 1 year ago

Context

On non-Darwin platforms KVC is not supported, thus check in Variable.swift:115 is returning nil.

While this technically cannot be solved, it would be better to first attempt to get value via DynamicMemberLookup protocol conformance.

This change is required for Sourcery linux support: https://github.com/krzysztofzablocki/Sourcery/pull/1188

art-divin commented 1 year ago

👋🏻 Hello @djbe ,

I am finishing Linux support for Sourcery.

At the moment this line of code is a blocker, would it be possible to merge this MR anytime soon?

I can see that this repo is unmaintained. I have resources to setup CI here and maybe I'll need to merge some more MRs before Sourcery Linux port would be finished.

I'd love to be collaborator here and support the project 🙏🏻