search

stendro / msm8996_lge_kernel

Kernel for G5, V20 & G6
Other
26 stars 15 forks source link

The fix for qcom's glink.c file might contain some bugs. #27

Closed AShiningRay closed 2 years ago

AShiningRay commented 3 years ago

Despite increasing the array index to prevent it from accessing a negative one (C doesn't work like Python), making it access the zero index of the array might be incorrect and cause problems later. We won't know until we test it.

Related commit: 4dc0439749efa0186a6bd40e2464eac9fd765591

stendro commented 2 years ago

Sultan has a fix for this: https://github.com/kerneltoast/android_kernel_google_wahoo/commit/72a13270599dfd262fefdc3e0395bc0dfab5a795

You can see if we should use that one instead.

AShiningRay commented 2 years ago

Yep, both fixes work as far as the code is concerned but sultan's commit is cleaner, easier to understand, and broader than our fix, so we can benefit of using his changes. Closing this one as well.