stenjo / SbankenToYNAB

Importing data from Sbanken to YNAB using Sbanken API and python 3
25 stars 5 forks source link

sync issues #32

Open stenjo opened 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #32 (9b7507f) into master (7384551) will increase coverage by 49.49%. The diff coverage is 97.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage    4.93%   54.43%   +49.49%     
===========================================
  Files          92       11       -81     
  Lines        6459      733     -5726     
===========================================
+ Hits          319      399       +80     
+ Misses       6140      334     -5806     
Impacted Files Coverage Δ
helpers/Helpers.py 66.66% <87.50%> (+4.16%) :arrow_up:
Helpers_test.py 97.00% <100.00%> (+0.90%) :arrow_up:
ynab/models/user.py
ynab/models/month_summaries_wrapper.py
ynab/models/bulk_transactions.py
ynab/models/transactions_wrapper.py
ynab/__init__.py
ynab/ynab/accounts_api.py
ynab/models/categories_response.py
ynab/models/category_groups_wrapper.py
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7384551...9b7507f. Read the comment docs.

alekslyse commented 1 year ago

Burde det kanskje ikke være greit å merge denne, og rengjøre de løse trådene slik en evt fork hadde vært enklere? Scriptet fugerer i dag enda, men da må bruke sync pull-en, og vil være forvirrende for nybegynnere.