search

steno-aarhus / osdc

Open-Source Diabetes Classifier: an R package to classify diabetes status in Danish registers
https://steno-aarhus.github.io/osdc/
Other
1 stars 1 forks source link

feat: ✨ add `include_podiatrist_services()` #155

Open signekb opened 2 months ago

signekb commented 2 months ago

Note: This PR is a work in progress. I will split it up into smaller/atomic PRs when we return to this project

Description

This PR adds include_podiatrist_services().

For this, I have:

  1. Added the logic to algorithm.csv
  2. Regenerated the package data with the targets pipeline (i.e., you don't have to look at the files in _targets/ and data/)
  3. Updated the regex logic in get_algorithm() to include regex logic that's in a parenthesis
  4. Added tests for get_algorithm (I'm not sure we need this, but I made it to test the updated regex, so I thought why not)
  5. Added a helper function to transform the honuge wwyy format to a hmd date with tests
  6. Added the inclusion function include_podiatrist_services() with tests

Notes: This PR is stacked on #138 to avoid merge conflicts in algorithm.csv

signekb commented 2 months ago

@lwjohnst86 Since this is a stacked PR, it doesn't require reviews to be merged. Should we add a protection rule for stacked PRs like we have for PRs to main?