build: update files based on check warnings and errors.

steno-aarhus / osdc

Open-Source Diabetes Classifier: an R package to classify diabetes status in Danish registers

https://steno-aarhus.github.io/osdc/

Other

1 stars 1 forks source link

build: update files based on check warnings and errors. #64

Closed lwjohnst86 closed 6 months ago

lwjohnst86 commented 6 months ago

One good habit to get into is to run checks before pushing. You run a check with Ctrl-Shift-E while in RStudio or devtools::check() in the Console. This does basic checks that would fulfill the requirements of CRAN. This PR is fixing most of these issues that have shown up. Review the commit history to see why I've changed each thing.

Aastedet commented 6 months ago

When I CTRL-SHIFT-E, it fails due to arrow and duckdb-packages not being installed, but works fine after installing them. I have a naive question: should they be in the dependencies/imports?

lwjohnst86 commented 6 months ago

@Aastedet they are in the Suggests section of the DESCRIPTION file. To install all dependencies, you can use the pak::pak() function to install even Suggests.