stenyak / breakbot

WhatsApp<->IRC gateway bot
90 stars 38 forks source link

Again ":" Bugs. But only if special things written. #28

Open h1rule opened 9 years ago

h1rule commented 9 years ago

Hello.

It looks like when we write

K :p

The message before "p" doesnt show up:

What sent: http://www.capsload.it/images/1413876846.jpg

What received: http://www.capsload.it/images/1413876875.png

Using latest version.

stenyak commented 9 years ago

Sometimes it's hard to distinguish between smilies and messages. For example: someone :k --> you're telling someone "okay" (abbr. as "k") something :p --> you're just using the ":-P" smiley (abbr. as ":p")

":k" might actually be a smiley in some culture (I don't know, "angry moustache" or whatever), so it may have different meanings depending on the context.

So far I've been using a whitelist of smilies, which filters messages that start with ":-", ":)", ":(" and ":/", as you can see here: https://github.com/stenyak/breakbot/blob/master/message.py#L18

If you want additional smilies to work, please add them there.

stenyak commented 9 years ago

Or maybe I should assume ":" is a smiley and ": " is a nick/message separator...

stenyak commented 9 years ago

Accidentally deleted a comment, sorry :-/