steos / reactcards

devcards for react

BSD 3-Clause "New" or "Revised" License

486 stars 29 forks source link

Consider Iframe for rendering basic cards. #12

Open jhicken opened 8 years ago

jhicken commented 8 years ago

If your component has a position fixed style. Things are ungood. If we Iframe it up we should be able to dodge that bullet.

Thoughts?

busypeoples commented 8 years ago

Sounds good.

busypeoples commented 8 years ago

@jhicken want to give it a try?

jhicken commented 8 years ago

13

There you go have a peek.

Sorry I have been aloof I want to contribute with a few more things but Im busy as of late.

busypeoples commented 8 years ago

@jhicken Thanks! @steos what do you think?

steos commented 8 years ago

@jhicken thanks for your work! Looks good to me, but I get a strange warning with those changes:

Warning: exception thrown by devtool while handling onSetChildren: Expected onMountComponent() to fire for the child before its parent includes it in onSetChildren().

Not sure what's the issue here, any ideas?

jhicken commented 8 years ago

I dug into it a bit yesterday. I didn't find the cause. But I know that the test cards cause the error on first render. Also the stateful card changes make it happen. I have a guess that its related to something happening durring the translation in react-frame-component but not totally sure yet.