search

step-up-labs / firebase-storage-dotnet

C# library for Firebase Storage
MIT License
140 stars 35 forks source link

Optionally set Mime-type #18

Closed tommed closed 6 years ago

tommed commented 6 years ago

Completed following work with passing unit test:

  1. Mime type can now be set when uploading file (ticket)
  2. Fix bug with TimeSpan being compared to a null when it's a value type
bezysoftware commented 6 years ago

Hi, I went over the PR and it looks good. Just one small thing - the tests shouldn't really be called "UnitTests", but rather IntergrationTests. Perhaps Tests for the solution and IntegrationTests for the csproj. If you could just rename those, I will then merge the PR

tommed commented 6 years ago

Hi there, not too familiar with the PR process with forks, but I believe that rename should now be in the same PR?

bezysoftware commented 6 years ago

Yep, that's fine. Thanks for the contribution!

tommed commented 6 years ago

Pleasure was mine. Looking forward to the updated nuget package!