search

stepancheg / grpc-rust

Rust implementation of gRPC
MIT License
1.37k stars 124 forks source link

Openssl dependency version too low - doesn't compile. #146

Open Ten0 opened 5 years ago

Ten0 commented 5 years ago

Somewhere in the dependency tree is the crate openssl 0.9, which is too old for my openssl version.

This causes the following issue : https://github.com/sfackler/rust-openssl/issues/987

This is specifically due to: httpbis -> tls-api-openssl -> openssl 0.9.*

You may consider switching to an http implementation more widely used which may be updated better, and also of better quality. Note that openssl was updated to 0.10 two months ago already.

stepancheg commented 5 years ago

Yes, it should be upgraded.

It is not trivial, because last time I tried, something was broken in openssl related to ALPN.

omac777 commented 5 years ago 
   Compiling tokio-io v0.1.12
error: failed to run custom build command for `openssl v0.9.24`
process didn't exit successfully: `/home/davidm/grpc-rust/target/debug/build/openssl-4c7d13669b8daf74/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Unable to detect OpenSSL version', /home/davidm/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-0.9.24/build.rs:16:14
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

davidm@io-02-z620:~/grpc-rust$ pkg-config --modversion openssl
1.1.1
davidm@io-02-z620:~/grpc-rust$ pkg-config --cflags --libs openssl
-lssl -lcrypto

I can confirm grpc-rust still does not compile with the latest openssl libraries.