Add a way to bring your own tokio event loop

stepancheg / grpc-rust

Rust implementation of gRPC

MIT License

1.38k stars 124 forks source link

Add a way to bring your own tokio event loop #154

Closed weiznich closed 5 years ago

weiznich commented 5 years ago

Sometimes it is required to reuse the underlying event loop in a other context. httpbis seems to support that. This PR only exposes that through the grpc::Client constructors.

stepancheg commented 5 years ago

LGTM, two comments:

fix CI please?
Client construction API should be eventually changed to builder as in httpbis, these 5-parameter methods are not very user friendly

stepancheg commented 5 years ago

Thank you!