search

stepancheg / grpc-rust

Rust implementation of gRPC
MIT License
1.38k stars 125 forks source link

Made ClientBuilderType::Unix depend on #[cfg(unix)] to avoid compile-… #162

Closed Tim-S closed 4 years ago

Tim-S commented 4 years ago

…error on windows

after i got the new Streaming API running with https://github.com/stepancheg/grpc-rust/pull/153, i ran into the follwoing issue on a windows target: grpc-rust-bug-set_unix_addr_not_found_on_windows

The changes proposed in this PR fixed that issue by excluding the ClientBuilderType::Unix when build on a non unix target

Tim-S commented 4 years ago

(Depends on https://github.com/stepancheg/grpc-rust/pull/153)

stepancheg commented 4 years ago

I have removed #[cfg(unix)] from rust-http2 instead. Should work now (didn't check though).

stepancheg commented 4 years ago

Thanks!