Generates code with allow(clippy) instead of allow(clippy::all)

stepancheg / grpc-rust

Rust implementation of gRPC

MIT License

1.38k stars 125 forks source link

Generates code with allow(clippy) instead of allow(clippy::all) #178

Closed jknovi closed 4 years ago

jknovi commented 4 years ago

This is causing some deprecated warnings.

Just need to change this line:

https://github.com/stepancheg/grpc-rust/blob/master/grpc-compiler/src/codegen.rs#L45

ec2 commented 4 years ago

Seeing the same issue here. Is there a way to get Clippy to ignore those generated files meanwhile?

jknovi commented 4 years ago

I wasn't able to ignore them, right now my "work-around" is to build grpc-rust locally with a patch, that I'm planning to send a PR soon-ish (my contractual obligations force me to do some bureaucratic paperwork before contributing to open source :( ) , but is just one line, if you have the time to spare is a low-hanging fruit.

ec2 commented 4 years ago

Just opened a PR on that :)

stepancheg commented 4 years ago

Published 0.7.1. Please let me know if need to be merged into 0.6 branch.