search

stepancheg / grpc-rust

Rust implementation of gRPC
MIT License
1.38k stars 125 forks source link

add content-type in headers_500 function #188

Closed pwang7 closed 3 years ago

pwang7 commented 3 years ago

headers_500 function misses content-type field when sending error response, which results in client failed to read the grpc status.

closes #187

stepancheg commented 3 years ago

While I have no strong objection to this, I'd like to know better why it matters.

Are you talking about interop with another implementation?

pwang7 commented 3 years ago

While I have no strong objection to this, I'd like to know better why it matters.

Are you talking about interop with another implementation?

Yes, I'm using grpc-rust as server side, and golang as client side. Without content-type in headers_500, the golang client side won't recognize the grpc error code.

stepancheg commented 3 years ago

Thanks! Please let me know if you need a version released.

pwang7 commented 3 years ago

Thanks! Please let me know if you need a version released.

I'll be great to have a new release asap, thanks!

stepancheg commented 3 years ago

Published 0.8.2

pwang7 commented 3 years ago

Thanks a lot!