search

stepancheg / grpc-rust

Rust implementation of gRPC
MIT License
1.37k stars 124 forks source link

consider building tokio-tls and openssl optionally #60

Open siddontang opened 7 years ago

siddontang commented 7 years ago

@stepancheg

I see that now grpc imports tokio-tls and openssl but doesn't use it anywhere. Users should install openssl to build even they don't want to use TLS.

Maybe we can use a optional feature to control it.

stepancheg commented 7 years ago

I agree.

siddontang commented 7 years ago

/cc @overvenus

Maybe we can send a PR later.

rschulman commented 7 years ago

I would recommend that if TLS is made optional, the default should be to have it operational. We should encourage the use of TLS.

stepancheg commented 7 years ago

Probably better option would be making TLS implementation optional in native-tls crate. I've created a feature-request.

eberkund commented 6 years ago

Looks like that issue was closed unfortunately :(