http2: handle client stream send error

stepancheg / grpc-rust

Rust implementation of gRPC

MIT License

1.37k stars 124 forks source link

http2: handle client stream send error #65

Closed overvenus closed 7 years ago

overvenus commented 7 years ago

When a client stream receiver dropped, http2 client panics with an error message SendError("..."). This PR removes the dropped stream and close the corresponding remote.

stepancheg commented 7 years ago

Could you please explain, how to reproduce an error? I need to write a test case before applying the patch.

stepancheg commented 7 years ago

I think I fixed the issue in https://github.com/stepancheg/rust-http2/commit/172915640d6a1080dff4a261e324fcd9b12d36ef.

However, in my patch, died client does not cancel the call, I've created a separate issue for that: https://github.com/stepancheg/rust-http2/issues/2.

overvenus commented 7 years ago

Well done! Sorry for the super later reply, I have been busy with my graduation project lately.