search

stepancheg / grpc-rust

Rust implementation of gRPC
MIT License
1.37k stars 124 forks source link

Crates.io depends on wrong httpbis #87

Closed bspeice closed 7 years ago

bspeice commented 7 years ago

Currently, grpc v0.1.11 depends on httpbis v0.2.0, which isn't compiling currently (due to error: pub(restricted) syntax is experimental (see issue #32409)).

While I see you marked in the Cargo.toml it wants 0.3.1, crates.io claims a dependency on ^0.2.

bspeice commented 7 years ago

As an update: If you use grpc from Git instead, the dependency works correctly, but the same issue is there. I think the actual solution is that a beta (currently 0.19.0) compiler is required, which would be helpful to note in the setup instructions.

stepancheg commented 7 years ago

pub(restricted) is stable in rust 1.18, and latest stable is 1.18.

stepancheg commented 7 years ago

Here is the proof that httpbis works in stable.

bspeice commented 7 years ago

No kidding, looks like I was on a different compiler than I thought I was. My apologies. I would still contend that I'm installing httpbis 0.2.0, where the Cargo.toml specifies 0.3.1.

stepancheg commented 7 years ago

Could you please explain again what is the issue?

I've just tried to compile dummy project with Cargo.toml:

[package]
name = "xxxx"
version = "0.1.0"
authors = ["Stepan Koltsov <stepan.koltsov@gmail.com>"]

[dependencies]
grpc = "0.1.11"

It compiles fine.

bspeice commented 7 years ago

Me not thoroughly checking the released vs. master Cargo.toml. I thought it should have been building against 0.3.1, but I was mistaken. My apologies. All good!

stepancheg commented 7 years ago

No problem. If you have any more questions, please don't hesistate to ask!