Support Unix domain sockets

stepancheg / grpc-rust

Rust implementation of gRPC

MIT License

1.37k stars 124 forks source link

Support Unix domain sockets #95

Closed bblancha closed 5 years ago

bblancha commented 7 years ago

Add options to client and serverbuilder for generating servers/clients which use Unix domain sockets.

Addresses #91

bblancha commented 7 years ago

Note: This won't successfully build until a new version of httpbis is released. I tested locally by manually pointing grpc/Cargo.toml to master of rust-http2.

przygienda commented 5 years ago

So what happened here. httpbis has pulled in the changes but this pullup stagnated?

bblancha commented 5 years ago

Yes, originally this PR was waiting on the next httbis release, but things slowed down and I did not revisit it.

If it is to be picked back up again, it should probably be redone with impl traits

przygienda commented 5 years ago

I kind of need it so willing to help ... look pretty decent to me as it is but am willing to listen ;-) ...

przygienda commented 5 years ago

awfully quiet, I probably grab a new branch (this one got deleted?) and apply your patch, roll it forward ...

bblancha commented 5 years ago

Yes, sounds good. Let me know if there are problems resolving the conflicts, and I will take a look. I haven't followed this project in a while, so I'm not sure what the changes look like.