search

stepanstipl / homebrew-noop

Personal tap for homebrew formulas
MIT License
5 stars 4 forks source link

Replace sha1 with sha256 since sha1 is now deprecated #6

Closed apsey closed 7 years ago

apsey commented 7 years ago

Also, updated rpm4 version to a new one, since old link was broken.

stepanstipl commented 7 years ago

HI @apsey, thanks this looks great. I don't really actively maintain this anymore, as I'm not using it anymore myself, but happy to see someone is, so thanks for this.

Some minor things - I think that as you also updated version of rpm to 4.13, this needs to be updated - https://github.com/stepanstipl/homebrew-noop/blob/1acec98048ae89702c62b307cef92b3d84ba0af0/spec/default/rpm4_spec.rb#L4 and ideally readme as well - https://github.com/stepanstipl/homebrew-noop/blob/f5af662e43f31db1566f41299b437fcb4280d318/README.md#L34. Otherwise it looks good. 👍

apsey commented 7 years ago

@stepanstipl Thanks! I've just updated both the README and the failing rspec test.

stepanstipl commented 7 years ago

Cool, looks good, thanks again.