search

stepanzubkov / where-is-my-sddm-theme

:eyes: The most minimalistic and highly customizable SDDM theme.
MIT License
191 stars 10 forks source link

feat: add wallpaper feature #1

Closed raihanadf closed 1 year ago

raihanadf commented 1 year ago

Don't get me wrong but I love this theme so much, it's so ultra minimalistic and fits my needs. I'm just thinking that it would be great if this theme has an optional wallpaper support.

stepanzubkov commented 1 year ago

:smirk: Hi! I'm glad to see that you like my theme. Also I am interested in your idea and tested it on my computer. But it does not work properly. Your mistakes were: 1) You did not delete color: bgColor line in background main Rectangle, so background was always black. 2) Even if backgroundFill is not set, the background is still black, because basic color of qml's Rectangle is not transparent.

I fix these bugs, and now theme works properly :) You can add screenshots of theme with wallpaper to README if you want (Especially if you have beautiful wallpaper). Thanks for contribution!

raihanadf commented 1 year ago

Yea forgot to check all those, but thanks! and is this gonna get merged soon?