stepb / urxvt-tabbedex

Tabbed plugin for rxvt-unicode with many enhancements
75 stars 54 forks source link

Unwanted margin at the bottom of the window #10

Open ghost opened 12 years ago

ghost commented 12 years ago

I have a margin between the last line and the bottom limit of the window when using tabbedex.

When starting urxvt, this space appear a bit darker: http://i.imgur.com/y7M1T.png When opening a new tab, this grey area disappears but its space stays unused by the application (like Irssi or Orpie): http://i.imgur.com/7OeHK.png

I don't have this problem when using the normal "tabbed" interface: http://i.imgur.com/e6pDQ.png

I use Arch with the latest version of Gnome, urxvt and urxvt-tabbeded (from the AUR). The scrollbar is deactivated in .Xdefaults.

cmm commented 12 years ago

To fix this, add the following hook to your copy of tabbedex (taken from the stock tabbed, don't know why it wasn't retained in tabbedex):

sub on_resize_all_windows {
    my ($self, $width, $height) = @_;

    1
}
ghost commented 12 years ago

I doesn't work.

There is the following in tabbedex, in sub on_init:

 $self->resource (name => "URxvt.tabbed");

I've never used perl but I imagine that it inherits from tabbed already.

cmm commented 12 years ago

Well, works for me and at least one other person... (No, tabbedex does not inherit from tabbed in any run-time sense, it just started from tabbed's code).

ghost commented 12 years ago

You just paste that at the end of /usr/lib/urxvt/perl/tabbedex? I still get that margin, although it's not visible anymore.

cmm commented 12 years ago

Hmm, I don't know if the "at the end" part makes a difference, though perhaps it could (because, as far as my (horribly rusty) Perl knowledge suggests, that would put the hook in the urxvt::ext::tabbedex::tab package and not in whatever package the rest of the file's definitions sit in). Then again, considering the fact that you do see some effect, it probably doesn't matter.

Could be down to your window manager, I guess. Mine is Awesome, and that other person uses Afterstep. Sorry, that's probably about all the technical expertise that I can muster on the subject. :(

ghost commented 12 years ago

I've tried putting it elsewhere, I get no change. But actually I'm not sure I see some effect, the grey border used to appear sporadically. After removing this code, I still don't get it now.

I use Gnome for now.

unkie commented 12 years ago

A workaround is to use "-b 0" as a commandline option. (only tested with jpkotta's branch, which passes commandline options to tabs), or use the "internalBorder" resource.

mina86 commented 10 years ago

Does mina86/urxvt-tabbedex solve this?