search

stepcut / plugins

Dynamic linking and runtime evaluation of Haskell, and C, including dependency chasing and package resolution.
GNU Lesser General Public License v2.1
52 stars 17 forks source link

GHC 9.2 support is missing #16

Open Kleidukos opened 1 year ago

Kleidukos commented 1 year ago

Hi! I'd like to start using plugins for an application of my own.

I tried to depend on it with GHC 9.2 as my compiler, and the following message makes me think that plugins is still trying to look up the old module hierarchy:

src/System/Plugins/LoadTypes.hs:33:1: error:
    Could not find module ‘HscTypes’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
33 | import HscTypes
   | ^^^^^^^^^^^^^^^

You're probably busy, so would you accept a PR to fix this?

stepcut commented 1 year ago

Yes. In fact, accepting PRs and uploading a new version to hackage is the only work I do on this package.

Kleidukos commented 1 year ago

Got it! Thanks for being reactive. :)

Kleidukos commented 1 year ago

@stepcut Hi! @cgibbard and I have ported the package to the latest GHC releases. Due to the copious amount of CPP involved for (what are frankly ancient) versions of GHC, I wanted your permission to switch the support window to GHC 8.10 minimum. What do you think of this?

stepcut commented 1 year ago

Given the limited number of users of this package, GHC 8.10 sounds reasonable. If someone really needs to use an older compiler, they can just use an older version of the plugin. I say that as someone who is still using GHC 8.6.5 :)

bleedsa commented 6 months ago

I'm still getting this error with ghc 9.0.2, has anyone figured out a fix?