stepeos / pycarmodel_calibration

Calibration tool for the EIDM car following model
GNU General Public License v3.0
5 stars 0 forks source link

Add option timestep to the framework #3

Closed Domsall closed 5 months ago

Domsall commented 5 months ago

I am testing a new timestep-option to calibrate the models with coarse data.

Until now, the 0.04s seem to be hard-coded.

Domsall commented 5 months ago

@stepeos Sorry, I committed to my previous branch. I didn't see that you had already merged it.

Domsall commented 5 months ago

@stepeos Please check modifications and merge. The changes work on my side, although the coveredDistance is not fully correct anymore.

stepeos commented 5 months ago

I already merged but now I'm thinking it might be smarter to put it into the data-config json file since it's not an 'action' but rather specific to a data set

Domsall commented 5 months ago

I have no preference. You can leave it as it is or change it. On my side, everything works fine, so I will close this.